On 8/8/06, Pavel Machek <[email protected]> wrote:
/* Parse position data: */
x = *(s16*)(data.val+EC_ACCEL_IDX_XPOS1);
y = *(s16*)(data.val+EC_ACCEL_IDX_YPOS1);
transform_axes(&x, &y);
...which looks even better to me.
Yes, that's elegant. But it made me realize there's a race condition here (and and also in the mainline driver): the global pos_x, rest_x etc. could be updated while an attribute's show_* function is called. Ugh. I guess I need to sprinkle spinlocks all over the place. Shem - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: Pavel Machek <[email protected]>
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- References:
- [PATCH 00/12] ThinkPad embedded controller and hdaps drivers
- From: Shem Multinymous <[email protected]>
- [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: Shem Multinymous <[email protected]>
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: Pavel Machek <[email protected]>
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: "Shem Multinymous" <[email protected]>
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: Pavel Machek <[email protected]>
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: "Shem Multinymous" <[email protected]>
- Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- From: Pavel Machek <[email protected]>
- [PATCH 00/12] ThinkPad embedded controller and hdaps drivers
- Prev by Date: Re: Only 3.2G ram out of 4G seen in an i386 box
- Next by Date: [PATCH] unserialized task->files changing
- Previous by thread: Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- Next by thread: Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
- Index(es):
 |