On 8/8/06, Greg KH <[email protected]> wrote:
> > >> +module_param_named(debug, tp_debug, int, 0600);
> > >> +MODULE_PARM_DESC(debug, "Debug level (0=off, 1=on)");
> > >> +
> > >> +/* A few macros for printk()ing: */
> > >> +#define DPRINTK(fmt, args...) \
> > >> + do { if (tp_debug) printk(KERN_DEBUG fmt, ## args); } while (0)
> > >
> > >Is not there generic function doing this?
> >
> > None that I found. Many drivers do it this way.
>
> linux/kernel.h : pr_debug() looks similar.
Use dev_dbg() and friends please instead of rolling your own.
But both pr_debug() and dev_dbg() do a static "#ifdef DEBUG", not a
runtime check of the 'debug' module paraeter.
Anyway, it turns out I don't really have any interesting debug outputs
anymore, so I'm eliminating DPRINTK() and the 'debug' module
parameter.
I'm still rolling my own printk formatting macro because thinkpad_ec
doesn't have a device for dev_dbg().
Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
