On Mon, 7 Aug 2006 13:44:41 +0000 Pavel Machek wrote:
> Hi!
>
> > The embedded controller on ThinkPad laptops has a non-standard interface
> > at IO ports 0x1600-0x161F (mapped to LCP channel 3 of the H8S chip).
> > The interface provides various system management services (currently
> > known: battery information and accelerometer readouts). This driver
> > provides access and mutual exclusion for the EC interface.
> >
> > The mainline hdaps driver already uses this hardware interface (in an
> > incorrect and unsafe way), and will be converted to use this module in
> > the following patches. Another driver using this module, tp_smapi, will
> > be submitted later.
> >
> > The Kconfig entry is set to tristate and will be selected by hdaps and
> > (eventually) tp_smapi, since thinkpad_ec does nothing by itself.
> >
> > Signed-off-by: Shem Multinymous <[email protected]>
>
> Signed-off-by: Pavel Machek <[email protected]>
>
> > +/* Module parameters: */
> > +static int tp_debug = 0;
>
> Static variables do not need initializers.
>
> > +module_param_named(debug, tp_debug, int, 0600);
> > +MODULE_PARM_DESC(debug, "Debug level (0=off, 1=on)");
> > +
> > +/* A few macros for printk()ing: */
> > +#define DPRINTK(fmt, args...) \
> > + do { if (tp_debug) printk(KERN_DEBUG fmt, ## args); } while (0)
>
> Is not there generic function doing this?
>
> > +/* thinkpad_ec_lock:
> > + * Get exclusive lock for accesing the controller. May sleep.
> > + * Returns 0 iff lock acquired .
> > + */
>
> Linuxdoc?
Yes. Usually known as kernel-doc.
See Documenation/kernel-doc-nano-HOWTO.txt for more info.
Thanks.
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
