On Tue, Aug 08, 2006 at 01:25:20AM +0200, Pavel Machek wrote:
> On Mon 2006-08-07 16:23:30, Greg KH wrote:
> > On Tue, Aug 08, 2006 at 01:15:57AM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > Thanks for the sign-offs!
> > >
> > > No problem.
> > >
> > > > >> +module_param_named(debug, tp_debug, int, 0600);
> > > > >> +MODULE_PARM_DESC(debug, "Debug level (0=off, 1=on)");
> > > > >> +
> > > > >> +/* A few macros for printk()ing: */
> > > > >> +#define DPRINTK(fmt, args...) \
> > > > >> + do { if (tp_debug) printk(KERN_DEBUG fmt, ## args); } while (0)
> > > > >
> > > > >Is not there generic function doing this?
> > > >
> > > > None that I found. Many drivers do it this way.
> > >
> > > linux/kernel.h : pr_debug() looks similar.
> >
> > Use dev_dbg() and friends please instead of rolling your own.
>
> Ahha, okay, dev_dbg() looks even better. (But we have pr_debug in
> linux/kernel.h; if it should not be used, comment would be nice).
Use pr_debug if you aren't doing driver things. But if you have a
device, please don't use it.
I guess we could add a comment for it, as if anyone would notice it...
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
