Hi!
> > >> >> + struct dmi_device *dev = NULL;
> > >> >unneeded initializer.
> > >> On a local variable?!
> > >
> > >You assign a new value to it on the next line, without ever using its
> > >initial value.
> >
> > The initial value is used in the last parameter to dmi_find_device():
> >
> > struct dmi_device *dev = NULL;
> > while ((dev = dmi_find_device(type, NULL, dev))) {
> > if (strstr(dev->name, substr))
> > return 1;
> > }
>
> Sorry, somehow my brain skipped the end of the line.
Ahha, sorry about that, I was blind, too. I thought it is because the
code is ugly, but now I see I was wrong.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
