On Mon, 7 Aug 2006 16:30:43 +0200 (CEST)
Jiri Kosina <[email protected]> wrote:
> acpi_pci_link_set() allocates with GFP_ATOMIC. On resume from suspend,
> this is called with interrupts off, otherwise GFP_KERNEL is safe.
>
> On the other hand, when resuming from suspend with interrupts off, the
> following callchain allocates with GFP_KERNEL, which is wrong:
>
> acpi_pci_link_resume -> acpi_pci_link_set -> acpi_set_current_resources ->
> acpi_rs_set_srs_method_data -> acpi_ut_create_internal_object_dbg ->
> acpi_ut_allocate_object_desc_dbg -> acpi_os_acquire_object ->
> kmem_cache_alloc(GFP_KERNEL) flag.
>
> Resending patch, which didn't make it into -rc4, to fix both issues. The
> patch is intentionally using irqs_disabled() and does not check in_resume
> flag, as this is marked for removal (which is for example how
> acpi_os_allocate() checks whether it should perform GFP_KERNEL or
> GFP_ATOMIC allocation).
acpi_os_acquire_object() is fixed in -rc4. I queued the
acpi_pci_link_set() improvement for sending on to Len, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
