Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h

Hi!

> > We have BUG_ON() right for this, don't we?
> 
> Well yes, but there are over a thousand BUG->BUG_ON conversion
> possibilities in the tree.  If people start sending them three-at-a-time
> we'll all go mad.
> 
> So.  If we're going to do this, bigger patches, please.

If we are going that way... I guess we should specify if BUG_ON() has
to evaluate its arguments even if it is compiled out...

Or probably better pecify that BUG_ON() must not have side effects?

							Pavel
-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
  - From: Adrian Bunk <[email protected]>

References:
- [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
  - From: Rolf Eike Beer <[email protected]>
- Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
  - From: Andrew Morton <[email protected]>

Prev by Date: Re: [patch] fix common mistake in polling loops
Next by Date: Re: [RFC/PATCH] revoke/frevoke system calls V2
Previous by thread: Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
Next by thread: Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]