Re: 2.6.18-rc3-g3b445eea BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug()

[Dave Jones <davej@redhat.com>]

On Sat, Aug 05, 2006 at 12:46:00AM -0700, Andrew Morton wrote:
 > @@ -320,10 +320,10 @@ void fastcall flush_workqueue(struct wor
 >  	} else {
 >  		int cpu;
 >  
 > -		lock_cpu_hotplug();
 > +		mutex_lock(&workqueue_mutex);
 >  		for_each_online_cpu(cpu)
 >  			flush_cpu_workqueue(per_cpu_ptr(wq->cpu_wq, cpu));
 > -		unlock_cpu_hotplug();
 > +		mutex_unlock(&workqueue_mutex);
 >  	}
 >  }

Is this enough though? I mean, what stops the hotplug cpu code
from modifying cpu_online_map underneath us here, making for_each_online_cpu
do the wrong thing ?

		Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/