Re: [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 4 Aug 2006 07:13:51 -0600
Keith Mannthey <[email protected]> wrote:
> I have worked to integrate the feedback I recived on the last round of patches
> and welcome more ideas/advice. Thanks to everyone who has provied input on
> these patches already. 
> 
Just from review...

If new zone , which was empty at boot, are added into the system.
build_all_zonelists() has to be called. (see online_pages() in memory_hotplug.c)
it looks x86_64's __add_pages() doesn't calles it.

Precisely, look online_pages() (CCONFIG_MEMORY_HOTPLUG_SPARSE) 
==
       setup_per_zone_pages_min();

        if (need_zonelists_rebuild)
                build_all_zonelists();
        vm_total_pages = nr_free_pagecache_pages();
==
These 3 calls are necessary, I think.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux