Re: [PATCH 27/28] elevate writer count for custom 'struct file'

On Tue, Aug 01, 2006 at 04:53:00PM -0700, Dave Hansen wrote:
> 
> Some filesystems forego the vfs and may_open() and create their
> own 'struct file's.  Any of these users which set the write flag
> on the file will cause an extra mnt_drop_write() on __fput(),
> thus dropping the reference count too low.
> 
> These users tend to have artifical in-kernel vfsmounts which
> aren't really exposed to userspace and can't be remounted, but
> this patch is included for completeness and so that the warnings
> don't trip over these cases.

Please add a helper to create these files so all this happens in just
one place.  There's a fare bit of code duplication already that this will
cleanup.  Another nice cleanup you should push out first before doing
the actual feature :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 27/28] elevate writer count for custom 'struct file'
    • From: Dave Hansen <[email protected]>

• References:
  • [PATCH 00/28] Mount writer count and read-only bind mounts (v5)
    • From: Dave Hansen <[email protected]>
  • [PATCH 27/28] elevate writer count for custom 'struct file'
    • From: Dave Hansen <[email protected]>

• Prev by Date: Re: [take3 1/4] kevent: Core files.
• Next by Date: Re: [RFC] [PATCH] Relative lazy atime
• Previous by thread: [PATCH 27/28] elevate writer count for custom 'struct file'
• Next by thread: Re: [PATCH 27/28] elevate writer count for custom 'struct file'
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]