Re: NFS root broken in 2.6.18-rc2-mm1

[Trond Myklebust <trond.myklebust@fys.uio.no>]

On Wed, 2006-08-02 at 06:50 +0200, Andi Kleen wrote:
> FYI,
> 
> I tried to boot 2.6.18-rc2-mm1 on a nfsroot system with x86-64 defconfig.
> 
> Unfortunately it seems to generate lots of random EIO while reading executables 
> during the startup sequence, which causes some things to break. Writing
> also doesn't seem to work - it complains about EPERM for that.
> Not all executables error out, but at least some.
> 
> The same setup works fine with mainline 2.6.18-rc*

Known issue. The attached patch ought to fix it...

Cheers,
  Trond

--- Begin Message ---

• Subject: No Subject
• From: Trond Myklebust <Trond.Myklebust@netapp.com>
• Date: Thu, 03 Aug 2006 10:21:56 -0400
• Nfs: Ensure NFSv2/v3 mounts respect the NFS_MOUNT_SECFLAVOUR flag

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---

 fs/nfs/super.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 867b5dc..d744f63 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -471,9 +471,10 @@ static int nfs_validate_mount_data(struc
 						data->version);
 				return -EINVAL;
 			}
-			/* Fill in pseudoflavor for mount version < 5 */
-			data->pseudoflavor = RPC_AUTH_UNIX;
 		case 5:
+			/* Set the pseudoflavor */
+			if (!(data->flags & NFS_MOUNT_SECFLAVOUR))
+				data->pseudoflavor = RPC_AUTH_UNIX;
 			memset(data->context, 0, sizeof(data->context));
 	}
 

--- End Message ---