Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code

On Thu, Aug 03, 2006 at 08:25:19AM +0200, Rolf Eike Beer wrote:

> > ./arch/x86_64/kernel/pci-swiotlb.c:6:#include <asm/dma-mapping.h>
> > ./drivers/net/fec_8xx/fec_main.c:40:#include <asm/dma-mapping.h>
> > ./drivers/net/fs_enet/fs_enet.h:11:#include <asm/dma-mapping.h>
> > ./include/asm-x86_64/swiotlb.h:5:#include <asm/dma-mapping.h>
> 
> I suspect it to be a bug anyway that every of this files ever included 
> asm/dma-mapping.h.

Agreed wrt the fs_enet and fec_8xx; the swiotlb stuff I dimly recall I
had a reason for. I'll take a look in bit to verify akpm's fix works.

> > ./include/linux/dma-mapping.h:27:#include <asm/dma-mapping.h>
> 
> This is perfectly valid, isn't it :)

:-)

Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • IOMMU (Calgary) patches
    • From: "Duran, Leo" <[email protected]>

• References:
  • [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
    • From: Rolf Eike Beer <[email protected]>
  • [PATCH] Move valid_dma_direction() from x86_64 to generic code
    • From: Rolf Eike Beer <[email protected]>
  • Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code
    • From: Muli Ben-Yehuda <[email protected]>
  • Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code
    • From: Rolf Eike Beer <[email protected]>

• Prev by Date: Re: [stable] Linux 2.6.17.6
• Next by Date: Re: [patch 7/8] Add a bootparameter to reserve high linear address space.
• Previous by thread: Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code
• Next by thread: IOMMU (Calgary) patches
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]