Re: [PATCH 0/6] AVR32 update for 2.6.18-rc2-mm1

[Trond Myklebust <trond.myklebust@fys.uio.no>]

On Tue, 2006-08-01 at 10:12 +0200, Haavard Skinnemoen wrote:
> On Mon, 31 Jul 2006 11:40:58 -0700
> Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> 
> > On Mon, 2006-07-31 at 17:46 +0200, Haavard Skinnemoen wrote:
> > > On Mon, 31 Jul 2006 15:55:15 +0200
> > > Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> > > 
> > > > Anyway, 2.6.18-rc2-mm1 boots successfully on my target with these
> > > > patches, but there's something strange going on with NFS and a few
> > > > other things that I didn't notice on 2.6.18-rc1. I'll investigate
> > > > some more and see if I can figure out what's going on.
> > > 
> > > All forms of write access to the NFS root file system seem to return
> > > -EACCESS. If I leave out git-nfs.patch, the problem goes away, so
> > > I'll try bisecting the NFS git tree tomorrow.
> > 
> > can you check in /proc/self/mountstats what mount options are set on
> > the root file system?
> 
> rw,vers=2,rsize=4096,wsize=4096,acregmin=3,acregmax=60,acdirmin=30,
> acdirmax=60,hard,nolock,proto=udp,timeo=11,retrans=2,sec=null

That 'sec=null' would explain why you are seeing a problem, and the
attached patch ought to fix it.

Cheers,
 Trond

--- Begin Message ---

• Subject: No Subject
• From: Trond Myklebust <Trond.Myklebust@netapp.com>
• Date: Tue, 01 Aug 2006 09:47:17 -0700
• Nfs: Ensure NFSv2/v3 mounts respect the NFS_MOUNT_SECFLAVOUR flag

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---

 fs/nfs/super.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 867b5dc..d744f63 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -471,9 +471,10 @@ static int nfs_validate_mount_data(struc
 						data->version);
 				return -EINVAL;
 			}
-			/* Fill in pseudoflavor for mount version < 5 */
-			data->pseudoflavor = RPC_AUTH_UNIX;
 		case 5:
+			/* Set the pseudoflavor */
+			if (!(data->flags & NFS_MOUNT_SECFLAVOUR))
+				data->pseudoflavor = RPC_AUTH_UNIX;
 			memset(data->context, 0, sizeof(data->context));
 	}
 

--- End Message ---