Re: Fwd: [PATCH] MODULE_FIRMWARE for binary firmware(s)

[Sam Ravnborg <sam@ravnborg.org>]

On Sat, Jul 29, 2006 at 08:06:14PM +0100, Jon Masters wrote:
> ---------- Forwarded message ----------
> From: Jon Masters <jonathan@jonmasters.org>
> Date: Apr 19, 2006 12:41 AM
> Subject: [PATCH] MODULE_FIRMWARE for binary firmware(s)
> To: akpm@osdl.org, linux-kernel@vger.kernel.org
> 
> 
> From: Jon Masters <jcm@redhat.com>
> 
> Right now, various kernel modules are being migrated over to use
> request_firmware in order to pull in binary firmware blobs from userland
> when the module is loaded. This makes sense.
> 
> However, there is right now little mechanism in place to automatically
> determine which binary firmware blobs must be included with a kernel in
> order to satisfy the prerequisites of these drivers. This affects
> vendors, but also regular users to a certain extent too.
> 
> The attached patch introduces MODULE_FIRMWARE as a mechanism for
> advertising that a particular firmware file is to be loaded - it will
> then show up via modinfo and could be used e.g. when packaging a kernel.
NAK.
Please provide some inline documentation so users knows how it is
supposed to be used etc. See MODULE_VERSION as an example.
Changelog comments is not enough documentation.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/