Re: Complete report of Null dereference errors in kernel 2.6.17.1

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Tom Walter Dillig wrote on 2006-07-25:
> [276]
> 1043, 1051, 1075, 1083, 1091, ... drivers/ieee1394/sbp2.c
> Possible null dereference of variable "hi" checked at
> (1096:drivers/ieee1394/sbp2.c).

Thanks for the report.

"hi" is guaranteed to be nonzero and valid at these places. The 
safeguards are the if clauses in lines 1042, 1050, 1074, 1082, 1090. 
Their conditions will evaluate to false if "hi" was NULL. This is 
because of the order of how members of struct scsi_id_instance_data are 
initialized in sbp2_alloc_device() and sbp2_start_device().

What other potential errors did your checker find in 
drivers/ieee1394/sbp2.c?
--
Stefan Richter
-=====-=-==- -=== ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/