On Fri, Jul 28, 2006 at 06:29:05PM +0200, Jan Engelhardt wrote:
>
> > Second iteration of the patchset to add color theme support to lxdialog.
> > This patchset allow the menuconfig user to select between a number of
> > different color themes for menuconfig:
> > blackbg, classic, mono and bluetitle
>
> Ain't nobody say the kernel lacks customization!
>
> It would have been nice to do the following,
>
> diff --fast -Ndpru -x '*.cmd' lxdialog~/util.c lxdialog/util.c
> --- lxdialog~/util.c 2006-07-28 16:37:28.499577000 +0200
> +++ lxdialog/util.c 2006-07-28 16:52:09.929577000 +0200
> @@ -63,6 +63,42 @@ do { \
> dlg.dialog.hl = (h); \
> } while (0)
>
> +static void set_classiciv_theme(void)
> +{
> + dlg = (const struct dialog_info){
> + .screen = {0, COLOR_CYAN, COLOR_BLUE, true},
> + .shadow = {0, COLOR_BLACK, COLOR_BLACK, true},
> ...
> + .uarrow = {0, COLOR_GREEN, COLOR_WHITE, true},
> + .darrow = {0, COLOR_GREEN, COLOR_WHITE, true},
> + };
> + return;
> +}
>
> Which uses a nice memcpy call rather than tons of MOVs (assembler insns).
> Unfortuantely it truncates ->title.
Current schme allows us to have a grand master theme that can be default
and then justified as needed - like in the 'bluetitle' case.
And for this purposes this is all about readability and not code-speed.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
