Christoph Hellwig wrote:
On Thu, Jul 27, 2006 at 01:32:43PM -0500, Eric Sandeen wrote:
Neil Brown wrote:
On Wednesday July 26, [email protected] wrote:
Hm, with this, ext3.ko has a new dependency on exportfs.ko. Is that
desirable/acceptable?
Drat, you're right.
No, I don't think that is what we want.
I'll do it differently in a day or so.
Would moving export_iget into fs/inode.c & exporting it from there be a
reasonable way to go? At least ext2 & ext3 both have this need (prevent
nfs access to special inodes) so putting the bulk of what they need for
get_dentry (i.e. export_iget) somewhere common seems like a decent
option to me.
Nope. The right fix is to not make ext2/3 rely on export_iget at all. Please
implement the proper export_operations instead, similar to e.g. xfs.
export_iget is a horrible layering violation that needs to go away long-term,
not move into core code.
Since export_iget() doesn't actually involve any code which has anything to
do with the NFS server exports data structures, what exactly is the
objection?
Is it truly better to duplicate code than to use a common routine which
can be documented?
Thanx...
ps
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
