Every time I try to decipher S_I* combos I cry in pain. Often I just
refer to include/linux/stat.h defines to find out what mode it is
because numbers are actually quickier to understand.
Compare and contrast:
0644 vs S_IRUGO|S_IWUSR vs rw_r__r__
I'd say #2 really sucks.
Another rationale: "ls -l" is used pretty often and people are used to
its output so new defines would be very easy to understand.
Target usage sysfs attributes modes and similar stuff. Driver authors
would just write
.attr = {.name = "state", .mode = r__r__r__ },
and be done with it.
I'm not sure you want to see
if (mode & _w__w__w_)
somewhere in generic code, this is debatable, so I'll go with attribute
stuff first.
What people think? Should folks at Moscow call 03 ASAP?
--- a/fs/smbfs/inode.c
+++ b/fs/smbfs/inode.c
@@ -575,10 +575,8 @@ static int smb_fill_super(struct super_b
mnt->flags = (oldmnt->file_mode >> 9) | SMB_MOUNT_UID |
SMB_MOUNT_GID | SMB_MOUNT_FMODE | SMB_MOUNT_DMODE;
} else {
- mnt->file_mode = S_IRWXU | S_IRGRP | S_IXGRP |
- S_IROTH | S_IXOTH | S_IFREG;
- mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP |
- S_IROTH | S_IXOTH | S_IFDIR;
+ mnt->file_mode = rwxr_xr_x | S_IFREG;
+ mnt->dir_mode = rwxr_xr_x | S_IFDIR;
if (parse_options(mnt, raw_data))
goto out_bad_option;
}
--- a/include/linux/stat.h
+++ b/include/linux/stat.h
@@ -29,6 +29,8 @@ #define S_ISBLK(m) (((m) & S_IFMT) == S_
#define S_ISFIFO(m) (((m) & S_IFMT) == S_IFIFO)
#define S_ISSOCK(m) (((m) & S_IFMT) == S_IFSOCK)
+#define rwxr_xr_x 0755
+
#define S_IRWXU 00700
#define S_IRUSR 00400
#define S_IWUSR 00200
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
