Re: XFS / Quota Bug in 2.6.17.x and 2.6.18x

[Alexey Dobriyan <adobriyan@gmail.com>]

On Thu, Jul 27, 2006 at 01:39:29PM +0200, ProfiHost - Stefan Priebe wrote:

Please regenerate patch with "diff -up" and sent it to
Nathan Scott <nathans@sgi.com>, CC'ing linux-fsdevel@vger.kernel.org,
xfs@oss.sgi.com

Also, read section 11 of Documentation/SubmittingPatches and if one of
clauses is applicable to you add appropriate "Signed-off-by" line.

> The crash only occurs if you use quota and IDE without barrier support.
> 
> The Problem is, that on a new mount of a root filesystem - the flag 
> VFS_RDONLY is set - and so no barrier check is done before checking 
> quota. With this patch barrier check is done always. The partition 
> should not be mounted at that moment. For mount -o remount, rw or 
> something like this it uses another function where VFS_RDONLY is checked.
> 
> Error Message:
> ns2 Wed Jul 26 14:22:58 2006 "I/O error in filesystem ("hda6") meta-data 
> dev
> hda6 block 0x23db5ab       ("xlog_iodone") error 5 buf count 1024"
> ns2 Wed Jul 26 14:22:58 2006 "xfs_force_shutdown(hda6,0x2) called from line
> 959 of file fs/xfs/xfs_log.c.  Return address = 0xc0211535"
> ns2 Wed Jul 26 14:22:58 2006 "Filesystem "hda6": Log I/O Error Detected.
> Shutting down filesystem: hda6"
> ns2 Wed Jul 26 14:22:58 2006 "Please umount the filesystem, and rectify the
> problem(s)"
> ns2 Wed Jul 26 14:22:58 2006 "xfs_force_shutdown(hda6,0x1) called from line
> 338 of file fs/xfs/xfs_rw.c.  Return address = 0xc0211535"
> ns2 Wed Jul 26 14:22:58 2006 "xfs_force_shutdown(hda6,0x1) called from line
> 338 of file fs/xfs/xfs_rw.c.  Return address = 0xc0211535"
> 
> Patch:
> *** fs/xfs/xfs_vfsops.c.orig	Thu Jul 27 13:10:23 2006
> --- fs/xfs/xfs_vfsops.c	Thu Jul 27 13:11:17 2006
> *************** xfs_mount(
> *** 524,528 ****
>   		goto error2;
> 
> ! 	if ((mp->m_flags & XFS_MOUNT_BARRIER) && !(vfsp->vfs_flag &
> VFS_RDONLY))
>   		xfs_mountfs_check_barriers(mp);
> 
> --- 524,528 ----
>   		goto error2;
> 
> ! 	if (mp->m_flags & XFS_MOUNT_BARRIER)
>   		xfs_mountfs_check_barriers(mp);
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/