Re: [PATCH] CCISS: Don't print driver version until we actually find a device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jesper Juhl <[email protected]> wrote:
> On 26/07/06, Bjorn Helgaas <[email protected]> wrote:

>> If we don't find any devices, we shouldn't print anything.
>>
> I disagree.
> I find it quite nice to be able to see that the driver loaded even if
> it finds nothing. At least then when there's a problem, I can quickly
> see that at least it is not because I didn't forget to load the
> driver, it's something else. Saves time since I can start looking for
> reasons why the driver didn't find anything without first spending
> additional time checking if I failed to cause it to load for some
> reason.

I disagree differently: the driver version is a function of the kernel
version, and the load status can easily be obtained. Therefore I suggest
never printing the version number from in-kernel drivers.

Maybe adding a debug kernel parameter that will cause module loads to be more
verbose for all modules is more reasonable.
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux