Re: [PATCH] RTC: Add mmap method to rtc character driver

> @@ -265,6 +269,7 @@ irqreturn_t rtc_interrupt(int irq, void 
>  
>  	kill_fasync (&rtc_async_queue, SIGIO, POLL_IN);
>  
> +	*count_ptr = (*count_ptr)++;

Hi,

it's a cute idea, however 3 questions:
1) you probably want to add a few memory barriers around this, right?
2) why use the rtc and not the regular timer interrupt?

(and 
3) this will negate the power gain you get for tickless kernels, since
now they need to start ticking again ;( )

Greetings,
   Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] RTC: Add mmap method to rtc character driver
    • From: Neil Horman <[email protected]>
  • Re: [PATCH] RTC: Add mmap method to rtc character driver
    • From: Jim Gettys <[email protected]>

• References:
  • [PATCH] RTC: Add mmap method to rtc character driver
    • From: Neil Horman <[email protected]>

• Prev by Date: Re: utrace vs. ptrace
• Next by Date: Re: [PATCH] RTC: Add mmap method to rtc character driver
• Previous by thread: [PATCH] RTC: Add mmap method to rtc character driver
• Next by thread: Re: [PATCH] RTC: Add mmap method to rtc character driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]