Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem

[Johannes Engel <j-engel@gmx.de>]

Thomas Tuttle schrieb:
> Here is a patch to the asus_acpi driver that links the Asus laptop LED's
> into the new LED subsystem.  It creates LED class devices named
> asus:mail, asus:wireless, and asus:touchpad, depending on if the laptop
> supports the mled, wled, and tled LED's.
> 
> Since it's so new, I added a config option to turn it on and off.  It's
> worked for me, though I have an Asus M2N, which only has the mail and
> wireless LED's.
> 
> Signed-off-by: Thomas Tuttle <thinkinginbinary@gmail.com>
> 
> 
> I believe I've fixed everything you asked about, plus a few things
> Richard Purdie (the LED subsystem guy) suggested.
> 
Thanks, Thomas, for your patch. It works well for me (ASUS V6V).
There is only one thing I want to remark: Since the most recent BIOS
ASUS changed the behaviour of the touchpad LED, it is inverted now.
Until now I got around this in userspace (adapting the handler script).
But with the new led class it seems to me, we will have to deal with
that in the kernel module.
My suggestion is a new flag (tled_inv) which has to be set for every
model (always use most recent BIOS). What do you think about this?

Greetings, Johannes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/