Re: [RFC][PATCH] A generic boolean (version 2)

[Jan Engelhardt <jengelh@linux01.gwdg.de>]

>> >* u2 has been corrected to u1 (and also added it as __u1)
>> 
>> Do we really need this? Is not 'bool' enough?
>
>I would say we don't even _want_ this.
>A u1 variable will basically never be one bit wide.

Not without a compiler hack at least.

>Consider:
>
>struct device_control_buffer {
>	u1 device_is_fooing;
>	u32 foodata;
>} __attribute__((packed));
>
>This would not lead to the expected results.
>It's horribly broken, obfuscating and misleading.

And in fact, bitfields work different:

struct device {
	int device_is_fooing:1;
	u32 foodata;
};

but the result is likely the same.


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/