RE: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

>diff --git a/drivers/acpi/hotkey.c b/drivers/acpi/hotkey.c
>index 32c9d88..037d022 100644
>--- a/drivers/acpi/hotkey.c
>+++ b/drivers/acpi/hotkey.c
>@@ -246,10 +246,8 @@ static char *format_result(union acpi_ob
> {
> 	char *buf = NULL;
> 
>-	buf = (char *)kmalloc(RESULT_STR_LEN, GFP_KERNEL);
>-	if (buf)
>-		memset(buf, 0, RESULT_STR_LEN);
>-	else
>+	buf = kzalloc(RESULT_STR_LEN, GFP_KERNEL);
>+	if (!buf)
> 		goto do_fail;

Go ahead and delete the '= NULL' while you're there.

Acked-by: Len Brown <[email protected]>

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: [RFC] input: Wacom tablet driver for simple X hotplugging
• Next by Date: Success: tty_io flush_to_ldisc() error message triggered
• Previous by thread: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
• Next by thread: [PATCH] sound: Conversions from kmalloc+memset to k(z|c)alloc.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]