Re: [PATCH 1/1] - sgiioc4: fixup use of mmio ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 19 Jul 2006 22:19:29 -0700
Jeremy Higdon <[email protected]> wrote:

> On Wed, Jul 19, 2006 at 10:31:55AM -0500, John Keller wrote:
> > Resend #2 changes include:
> > 
> > - use 'void __iomem *' for ioremap() return values,
> >   and handle error cases.
> > 
> > sgiioc4.c had been recently converted to using mmio ops.
> > There are still a few issues to cleanup.
> > 
> > Signed-off-by: [email protected]
> Signed-off-by: [email protected]

hrm.  I think we're owed a couple of iounmap()s, please.  One in the
ide_dma_sgiioc4() error path and one in the takedown path.

Maybe that was one of the "few issues to cleanup", but it's a pretty simple
one.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux