Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc

Added linux-scsi to CC as it touches drivers/scsi/

>  	/* stuff a sense request in front of our current request */
> -	pc = kmalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
> +	pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);

Please remove the space before the arguments.

>  	rq = kmalloc (sizeof (struct request), GFP_ATOMIC);

This and the one before should be "rq = kzalloc(sizeof(*rq),...);" This way 
you will always get the correct buffer size even if the type of rq changes.

Eike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc
    • From: [email protected] (Panagiotis Issaris)

• Prev by Date: Re: [PATCH] sound: Conversions from kmalloc+memset to k(z|c)alloc.
• Next by Date: Re: sound skips on 2.6.16.17
• Previous by thread: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc
• Next by thread: [PATCH 2/2] Forgotten memset
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]