Re: How to explain to lock validator: locking inodes in inode order

[Arjan van de Ven <arjan@infradead.org>]

On Mon, 2006-07-17 at 19:24 -0700, Joshua Hudson wrote:
> Code does this:
> 
> /* Lock two items. See locking.txt */
> static inline void kb0_lock2m(struct kb0_idata *m1, struct kb0_idata *m2)
> {
>         if (m1->vi.i_ino > m2->vi.i_ino)
>                 mutex_lock(&m2->k_mutex);
>         mutex_lock(&m1->k_mutex);
>         if (m1->vi.i_ino < m2->vi.i_ino)
>                 mutex_lock(&m2->k_mutex);
> }
> 
> Not sure how to explain to the lock validator that this code can never deadlock.

you're sure it can;t? (which fs is this btw?)

all places in the kernel that take this mutex in that order only do it
in i_ino order, including all directory operations like cross directory
rename?

(if so you can explain normal parent/child nesting, but only if so)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/