Re: [PATCH] nbd: Check magic before doing anything else

Michal Feix wrote:

We should check magic sequence in reply packet before trying to find
request with it's request handle. This also solves the problem with
"Unexpected reply" message beeing logged, when packet with invalid magic
is received.

Right. Again, we can't return NULL after pulling the request off the queue, so we better do this check first.

Andrew, these two look good to me.

Thanks,
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] nbd: Check magic before doing anything else
    • From: Michal Feix <[email protected]>

• Prev by Date: Re: adaptive read ahead patch?
• Next by Date: Re: Linux v2.6.17 - PCI Bus hidden behind transparent bridge
• Previous by thread: [PATCH] nbd: Check magic before doing anything else
• Next by thread: Using irqpoll option triggers the NMI Watchdog
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]