Re: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set

[Ingo Molnar <mingo@elte.hu>]

* Andi Kleen <ak@suse.de> wrote:

> On Sunday 16 July 2006 22:47, Ingo Molnar wrote:
> > * Andi Kleen <ak@suse.de> wrote:
> > >  unsigned long arch_align_stack(unsigned long sp)
> > >  {
> > > -	if (randomize_va_space)
> > > +	if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
> > >  		sp -= get_random_int() % 8192;
> > >  	return sp & ~0xf;
> >
> > i'm not opposing this patch at all, but didnt the performance problems
> > go away when the 0xf was changed to 0x7f?
> 
> Yes, but i sent the patch before that other patch was available.

excuses, excuses ;)

> I guess it's a separate issue anyways - this patch is just concerned 
> about disabling randomization consistently. Performance optimization 
> can be done in another one.

yeah. There's one security issue: the 'dont randomize' flag must be 
cleared when we cross a protection domain. When for example suid-ing in 
exec().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/