[2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000

[Shawn Starr <shawn.starr@rogers.com>]

Hardware

IBM ThinkPad T42
E1000 card info: 

02:01.0 Ethernet controller: Intel Corporation 82540EP Gigabit Ethernet 
Controller (Mobile) (rev 03)
        Subsystem: IBM PRO/1000 MT Mobile Connection
        Flags: bus master, 66MHz, medium devsel, latency 64, IRQ 9
        Memory at c0220000 (32-bit, non-prefetchable) [size=128K]
        Memory at c0200000 (32-bit, non-prefetchable) [size=64K]
        I/O ports at 8000 [size=64]
        [virtual] Expansion ROM at ec000000 [disabled] [size=64K]
        Capabilities: [dc] Power Management version 2

Steps to reproduce:

1) Suspend to disk normally
2) Resume from disk, the e1000 will show garbage for network statistics.

<snip>
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:83 errors:4294967254 dropped:4294967289 overruns:0 
frame:4294967268
          TX packets:76 errors:4294967282 dropped:0 overruns:0 
carrier:4294967275
          collisions:4294967289 txqueuelen:100
          RX bytes:50728 (49.5 KiB)  TX bytes:10138 (9.9 KiB)
          Base address:0x8000 Memory:c0220000-c0240000

Did something change in the driver that forgot to save the registers / not 
register back upon resumption from disk? I can't tell from the code how the 
driver knows its been brought down to S3 or S4 states.
 
A workaround is to then suspend to memory and resume, the e1000 will work 
again. This is repeatable each time.

Not sure if anyone else noticed this.

Thanks, 

Shawn.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/