Adrian Bunk wrote:
On Thu, Jul 13, 2006 at 10:48:00PM -0700, Andrew Morton wrote:
...
Changes since 2.6.18-rc1-mm1:
...
+gpio-rename-exported-vtables-to-better-match.patch
...
Misc fixes and updates and cleanups.
...
A static struct mustn't be exported.
I don't agree with unexporting pc8736x_gpio_ops. If anything the struct should
be made global and kept exported (as _GPL perhaps). This lets other modules use
the pc8736x_gpio module in a semi-independent way. See my comments about the
scx200_gpio changes you submitted.
Signed-off-by: Adrian Bunk <[email protected]>
--- linux-2.6.18-rc1-mm2-full/drivers/char/pc8736x_gpio.c.old 2006-07-14 22:27:28.000000000 +0200
+++ linux-2.6.18-rc1-mm2-full/drivers/char/pc8736x_gpio.c 2006-07-14 22:27:42.000000000 +0200
@@ -215,19 +215,18 @@
static struct nsc_gpio_ops pc8736x_gpio_ops = {
.owner = THIS_MODULE,
.gpio_config = pc8736x_gpio_configure,
.gpio_dump = nsc_gpio_dump,
.gpio_get = pc8736x_gpio_get,
.gpio_set = pc8736x_gpio_set,
.gpio_change = pc8736x_gpio_change,
.gpio_current = pc8736x_gpio_current
};
-EXPORT_SYMBOL(pc8736x_gpio_ops);
static int pc8736x_gpio_open(struct inode *inode, struct file *file)
{
unsigned m = iminor(inode);
file->private_data = &pc8736x_gpio_ops;
dev_dbg(&pdev->dev, "open %d\n", m);
if (m >= PC8736X_GPIO_CT)
Chris
--
Chris Boot
[email protected]
http://www.bootc.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
