Re: [linux-usb-devel] [PATCH] Properly unregister reboot notifier in case of failure in ehci hcd

[Alan Stern <stern@rowland.harvard.edu>]

On Fri, 14 Jul 2006, Aleksey Gorelov wrote:

> > This patch causes hangs at reboot/shutdown/suspend time.  See
> > http://www.zip.com.au/~akpm/linux/patches/stuff/dsc03597.jpg
> > 
> Oops, I did not test it with suspend/resume stuff, sorry. The problem is that ehci_run is called
> from resume without its counterpart ehci_stop in suspend, so notifier ends up registered twice.
> 
> David, Alan,
> 
> Do you think it is Ok to unregister reboot notifier in ehci_run before registering one to make
> sure there is no 'double registering' of notifier, or is it better to move register/unregister
> reboot notifier from ehci_run/ehci_stop completely to some other place ?

Dave has a better idea than I do about where a good spot might be for 
registering the notifier.

However, it is always possible to avoid "double registering" by keeping a
private flag that you set when the notifier is registered.  Then you can
simply skip registering if the flag is already set.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/