On Fri, 2006-07-14 at 16:53 +0200, Oliver Neukum wrote:
> Am Freitag, 14. Juli 2006 16:48 schrieb Steven Rostedt:
> > @@ -52,14 +54,16 @@ static inline void lock_cmos(unsigned ch
> >
> > static inline void unlock_cmos(void)
> > {
> > - cmos_lock = 0;
> > + set_wmb(cmos_lock, 0);
> > }
> > static inline int do_i_have_lock_cmos(void)
> > {
> > + barrier();
>
> Shouldn't these be rmb() ?
I was thinking that too, but I'm still not sure when to use rmb or
barrier. wmb seems pretty straight forward though. hmm, maybe this
really should be a smb_rmb since I believe a barrier would be ok for UP.
-- Steve
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
