Re: [patch] lockdep: annotate mm/slab.c

On Thu, 13 Jul 2006, Christoph Lameter wrote:

> The fix by removing the dropping of the lock in free_block could cause 
> retaking the list_lock that we already hold in the OFF_SLAB case (even in 
> the non NUMA case). 

That retaking only occurs if the general slab cache used for the cache 
management is the same general slab where we are freeing from.

Otherwise we are acquiring the list_locks of two distinct slab caches 
which may introduce an issue of lock ordering.

So reversing the patch seems to be the right measure after all. But we 
have the two weird locking scenarios above.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: "Alok kataria" <[email protected]>

• References:
  • Random panics seen in 2.6.18-rc1
    • From: Chandra Seetharaman <[email protected]>
  • Re: Random panics seen in 2.6.18-rc1
    • From: Ingo Molnar <[email protected]>
  • Re: Random panics seen in 2.6.18-rc1
    • From: Andrew Morton <[email protected]>
  • Re: Random panics seen in 2.6.18-rc1
    • From: Ingo Molnar <[email protected]>
  • Re: Random panics seen in 2.6.18-rc1
    • From: Andrew Morton <[email protected]>
  • [patch] lockdep: annotate mm/slab.c
    • From: Ingo Molnar <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: "Pekka Enberg" <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Linus Torvalds <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Arjan van de Ven <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Christoph Lameter <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Andrew Morton <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Christoph Lameter <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Christoph Lameter <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Andrew Morton <[email protected]>
  • Re: [patch] lockdep: annotate mm/slab.c
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [patch] lockdep: annotate mm/slab.c
• Next by Date: Re: [PATCH -mm 5/7] add user namespace
• Previous by thread: Re: [patch] lockdep: annotate mm/slab.c
• Next by thread: Re: [patch] lockdep: annotate mm/slab.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]