> I suspect it'll get really ugly. It's a container library which needs to
> allocate memory when items are added, like the radix-tree. Either it needs
> to assume GFP_ATOMIC, which is bad and can easily fail or it does weird
> things like radix_tree_preload().
Actually I don't think it has to be too bad. We could tweak the
interface a little bit so that consumers do something like:
struct idr_layer *layer = NULL; /* opaque */
retry:
spin_lock(&my_idr_lock);
ret = idr_get_new(&my_idr, ptr, &id, layer);
spin_unlock(&my_idr_lock);
if (ret == -EAGAIN) {
layer = idr_alloc_layer(&my_idr, GFP_KERNEL);
if (!IS_ERR(layer))
goto retry;
}
in other words make the consumer responsible for passing in new memory
that can be used for a new entry (or freed if other entries have
become free in the meantime).
- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Convert idr's internal locking to _irqsave variant
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Convert idr's internal locking to _irqsave variant
- From: Arjan van de Ven <[email protected]>
- Re: [PATCH] Convert idr's internal locking to _irqsave variant
- References:
- ipoib lockdep warning
- From: Zach Brown <[email protected]>
- Re: [openib-general] ipoib lockdep warning
- From: Roland Dreier <[email protected]>
- Re: [openib-general] ipoib lockdep warning
- From: Zach Brown <[email protected]>
- Re: [openib-general] ipoib lockdep warning
- From: Roland Dreier <[email protected]>
- Re: [openib-general] ipoib lockdep warning
- From: Ingo Molnar <[email protected]>
- [PATCH] Convert idr's internal locking to _irqsave variant
- From: Roland Dreier <[email protected]>
- Re: [PATCH] Convert idr's internal locking to _irqsave variant
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Convert idr's internal locking to _irqsave variant
- From: Roland Dreier <[email protected]>
- Re: [PATCH] Convert idr's internal locking to _irqsave variant
- From: Andrew Morton <[email protected]>
- ipoib lockdep warning
- Prev by Date: lockdep problem in bcm43xx
- Next by Date: Re: [PATCH] Convert idr's internal locking to _irqsave variant
- Previous by thread: Re: [PATCH] Convert idr's internal locking to _irqsave variant
- Next by thread: Re: [PATCH] Convert idr's internal locking to _irqsave variant
- Index(es):
 |