Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Blaisorblade wrote:
On Wednesday 12 July 2006 18:40, Jeff Dike wrote:
Sysrq works fine on UML.

Signed-off-by: Jeff Dike <[email protected]>

Index: linux-2.6.17/lib/Kconfig.debug
===================================================================
--- linux-2.6.17.orig/lib/Kconfig.debug	2006-07-12 11:26:41.000000000 -0400
+++ linux-2.6.17/lib/Kconfig.debug	2006-07-12 11:33:02.000000000 -0400
@@ -18,7 +18,6 @@ config ENABLE_MUST_CHECK

 config MAGIC_SYSRQ
 	bool "Magic SysRq key"
-	depends on !UML
 	help
 	  If you say Y here, you will have some control over the system even
 	  if the system crashes for example during kernel debugging (e.g., you
Please reject this patch, the setting for UML is just elsewhere, in arch/um/Kconfig (and depends on MCONSOLE).

If kbuild doesn't handle well having an option declared twice now (it isn't very happy but it worked when I added the above dependency) we can rename the one in arch/um/Kconfig to MAGIC_SYSRQ_UML and make the one above like this (untested):

config MAGIC_SYSRQ
	bool
	prompt "Magic SysRq key" if !UML
	depends on MAGIC_SYSRQ_UML || !UML
	default y if UML


Why not:

config MAGIC_SYSRQ
	bool
	prompt "Magic SysRq key"
	depends on !UML || MCONSOLE
	default y if UML

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux