2.6.18 Headers - Long

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 

I was really glad to see that something was going to be done with the headers, but I don't think it's enough. I'm going to share my concerns and hopefully we can all figure what is the right thing to do.
First off, my research in this has been going on since LLH announced that it was not going to produce any more headers. I started a project to sanitize the headers myself. http://headers.cross-lfs.org.
I will only document one issue, but there are several more like this in the kernel.
I'm going to use the MIPS architecture in my example, along with the file page.h.
With the 2.6.18 headers, the file that gets created looks like this. If you notice on lines 17, 20, 23, 26, and 34 they all use CONFIG_{...}, these variables are called from linux/autoconf.h. Yes, the simple fix would be to include this file. 

  1.
     /*
  2.
      * This file is subject to the terms and conditions of the GNU
     General Public
  3.
      * License.  See the file "COPYING" in the main directory of this
     archive
  4.
      * for more details.
  5.
      *
  6.
      * Copyright (C) 1994 - 1999, 2000, 03 Ralf Baechle
  7.
      * Copyright (C) 1999, 2000 Silicon Graphics, Inc.
  8.
      */
  9.
     #ifndef _ASM_PAGE_H
 10.
     #define _ASM_PAGE_H
 11.
12. 13. 14. 
     /*
 15.
      * PAGE_SHIFT determines the page size
 16.
      */
 17.
     #ifdef CONFIG_PAGE_SIZE_4KB
 18.
     #define PAGE_SHIFT      12
 19.
     #endif
 20.
     #ifdef CONFIG_PAGE_SIZE_8KB
 21.
     #define PAGE_SHIFT      13
 22.
     #endif
 23.
     #ifdef CONFIG_PAGE_SIZE_16KB
 24.
     #define PAGE_SHIFT      14
 25.
     #endif
 26.
     #ifdef CONFIG_PAGE_SIZE_64KB
 27.
     #define PAGE_SHIFT      16
 28.
     #endif
 29.
     #define PAGE_SIZE       (1UL << PAGE_SHIFT)
 30.
     #define PAGE_MASK       (~((1 << PAGE_SHIFT) - 1))
 31.
32. 33. 34. 
     #ifdef CONFIG_LIMITED_DMA
 35.
     #define WANT_PAGE_VIRTUAL
 36.
     #endif
 37.
38. 
     #include <asm-generic/memory_model.h>
 39.
     #include <asm-generic/page.h>
 40.
41. 
     #endif /* _ASM_PAGE_H */
Here's the header I produce with my sanitize script, I use a glibc call to get the information, which would be more appropriate for the user space. This is very similar to what LLH provided. Even my example is not prefect due to line 14. 

  1.
     #define _ASM_PAGE_H
  2.
3. 
     #include <unistd.h>
  4.
5. 
     #define PAGE_SIZE       (getpagesize())
  6.
     static __inline__ int getpageshift()
  7.
     {
  8.
         int pagesize = getpagesize();
  9.
         return (__builtin_clz(pagesize) ^ 31);
 10.
     }
 11.
     #define PAGE_SHIFT      (getpageshift())
 12.
     #define PAGE_MASK       (~(PAGE_SIZE-1))
 13.
14. 
     #ifdef CONFIG_LIMITED_DMA
 15.
     #define WANT_PAGE_VIRTUAL
 16.
     #endif
 17.
18. 
     #endif /* !(_ASM_PAGE_H) */
So even with the new headers_install, the headers still need to be sanitized to overcome the missing variables from linux/autoconf.h.
Just wanted to bring this up to everyone's attention and look forward to helping get things resolved. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux