Alan Cox <[email protected]> wrote:
>
> I'd say that gcc warning in the case that all the enum values are enumerated
> and have returns is a broken warning irrespective of that so I won't "fix" it
> because it isn't broken. Its just like various other bogus gcc warnings
>
But we work around gcc problems all the time.
Warnings like this have a cost - they make the build noisy and that causes
people to miss real bugs which the compiler is trying to tell them about.
So if we can implement a low-cost fix for this then we should do so.
--- a/drivers/ide/pci/jmicron.c~a
+++ a/drivers/ide/pci/jmicron.c
@@ -94,8 +94,9 @@ static int __devinit ata66_jmicron(ide_h
return 0;
return 1;
case PORT_SATA:
- return 1;
+ break;
}
+ return 1; /* Avoid bogus "control reaches end of non-void function" */
}
static void jmicron_tuneproc (ide_drive_t *drive, byte mode_wanted)
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
