Re: [PATCH] fdset's leakage

On Tuesday 11 July 2006 18:13, Vadim Lobanov wrote:
> > unsinged long round_up_pow_of_two(unsigned long x)
> > {
> >   unsigned long res = 1 << BITS_PER_LONG;
>
> You'll get a zero here. Should be 1 << (BITS_PER_LONG - 1).
>

Nope. It wont work on 64 bits platform :)

You want  1UL << (BITS_PER_LONG - 1).

But the roundup_pow_of_two() function is already defined in 
include/linux/kernel.h and uses fls_long()

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fdset's leakage
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] fdset's leakage
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] fdset's leakage
    • From: Vadim Lobanov <[email protected]>

• Prev by Date: Re: [klibc] klibc and what's the next step?
• Next by Date: Re: [klibc] klibc and what's the next step?
• Previous by thread: Re: [PATCH] fdset's leakage
• Next by thread: Re: [PATCH] fdset's leakage
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]