Re: [PATCH] fbdev: Statically link the framebuffer notification functions

On 7/11/06, Antonino A. Daplas <[email protected]> wrote:

> The code looks ok but this sure smells like inter_module_*.

I assure you, there is no smell of inter_module_* here. What scenario
are you afraid of?

Dangling references during the load/unload process. That was
inter_module's problem.

> I guess
> inter_module had to deal with arbitrary users and this code is dealing
> with a fixed set of clients which makes it more manageable.
>
> Have you considered making this a generic service and not fb specific?
>

It's basically a wrapper to the notifier_call_chain, that's as generic
as it can get. And yes, it's not fb_specific (meaning, there's no need
for the client module to know fbdev internals), that's why the lcd and
backlight subsystem can take advantage of it.

The generic code could create notifier chains with a name. The modules
would then use the name to attach. Now you don't need the fb_notifier
code.

--
Jon Smirl
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Antonino A. Daplas" <[email protected]>

• References:
  • Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1
    • From: Matt Reuther <[email protected]>
  • [PATCH] backlight: lcd: Remove dependency from the framebuffer layer
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH] backlight: lcd: Remove dependency from the framebuffer layer
    • From: Andrew Morton <[email protected]>
  • [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Jon Smirl" <[email protected]>
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Jon Smirl" <[email protected]>
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Jon Smirl" <[email protected]>
  • Re: [PATCH] fbdev: Statically link the framebuffer notification functions
    • From: "Antonino A. Daplas" <[email protected]>

• Prev by Date: Re: [PATCH 00/10] Kernel memory leak detector 0.8
• Next by Date: RE: Commenting out out_of_memory() function in __alloc_pages()
• Previous by thread: Re: [PATCH] fbdev: Statically link the framebuffer notification functions
• Next by thread: Re: [PATCH] fbdev: Statically link the framebuffer notification functions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]