Andrew Morton wrote:
> On Tue, 11 Jul 2006 15:04:08 +0800
> "Antonino A. Daplas" <[email protected]> wrote:
>
>> +#if defined(CONFIG_FB) || (defined(CONFIG_FB_MODULE) && \
>> + defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE))
>
> Peeking at CONFIG_FB_MODULE like this is considered sinful.
>
> <tries to remember why>
>
> Because someone might build a CONFIG_FB=n, CONFIG_FB_MODULE=n kernel, then
> later build the fbdev module for that kernel only to find that the
> backlight driver doesn't know that the fbdev module is available.
>
> Or something like that. It's pretty contrived, and I really doubt that
> anyone's going to try to cobble together a kernel like that.
>
> Or maybe there's a better reason...
That's the simplest method I can think of to prevent impossible
combinations such as CONFIG_FB=m, CONFIG_BACKLIGHT_CLASS_DEVICE=y
without having to use 'depend' or 'select' in Kconfig, or God forbid,
inter_module_get().
I should have added a comment that I also don't like the hackishness
of this method.
Thinking about this a little more carefully now, how about we just statically
link the fb notification?
I'll see if I can send an update for that.
Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
