Re: [2.6 patch] let BT_HIDP depend on INPUT

Hi Adrian,

> This patch let's BT_HIDP depend on instead of select INPUT.
> 
> This fixes the following warning during an s390 build:
> 
> <--  snip  -->
> 
> ...
> net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'INPUT'
> ...
> 
> <--  snip  -->
> 
> A dependency on INPUT also implies !S390 (and therefore makes the 
> explicit dependency obsolete) since INPUT is not available on s390.
> 
> The practical difference should be nearly zero, since INPUT is always 
> set to y unless EMBEDDED=y (or S390=y).

I actually have no idea why we ended up with using select, but depends
is also fine by me. Except I like to see it "BT && BT_L2CAP && INPUT" ;)

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [2.6 patch] let BT_HIDP depend on INPUT
    • From: Adrian Bunk <[email protected]>

• References:
  • [2.6 patch] let BT_HIDP depend on INPUT
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: 2.6.18-rc1-mm1 inconsistent lock state in netpoll_send_skb
• Next by Date: Re: [PATCH -rt] catch put_task_struct RCU handling up to mainline
• Previous by thread: [2.6 patch] let BT_HIDP depend on INPUT
• Next by thread: [2.6 patch] let BT_HIDP depend on INPUT
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]