Re: [RFC][PATCH 9/9] -Wshadow: fixes for drivers/char/keyboard.c

On 10/07/06, Dmitry Torokhov <[email protected]> wrote:

On 7/10/06, Jesper Juhl <[email protected]> wrote:
>
> -static void kbd_keycode(unsigned int keycode, int down,
> +static void kbd_keycode(unsigned int keycode, int _down,
>                        int hw_raw, struct pt_regs *regs)
>  {

I dont like the "_down" name, feels artificial. If you don't mind I'll
change it to "key_down" before applying.

Makes sense. Thank you for that feedback.
Working out if people liked the sort of name changes I'd done was
exactely one of the reasons I posted these patches - I'll think of
better names than just prefixing with "_" for future patches.

--
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 9/9] -Wshadow: fixes for drivers/char/keyboard.c
    • From: Jesper Juhl <[email protected]>
  • Re: [RFC][PATCH 9/9] -Wshadow: fixes for drivers/char/keyboard.c
    • From: "Dmitry Torokhov" <[email protected]>

• Prev by Date: Re: [RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow
• Next by Date: Re: linux-2.6.17(.4) : compile error in sound/pci/fm801.c and sound/pci/rme9652/hdsp.c
• Previous by thread: Re: [RFC][PATCH 9/9] -Wshadow: fixes for drivers/char/keyboard.c
• Next by thread: [RFC][PATCH 7/9] -Wshadow: fixes for checksum.h
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]