Re: [RFC][PATCH 9/9] -Wshadow: fixes for drivers/char/keyboard.c

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 10/07/06, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On 7/10/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> >
> > -static void kbd_keycode(unsigned int keycode, int down,
> > +static void kbd_keycode(unsigned int keycode, int _down,
> >                        int hw_raw, struct pt_regs *regs)
> >  {
>
> I dont like the "_down" name, feels artificial. If you don't mind I'll
> change it to "key_down" before applying.
Makes sense. Thank you for that feedback.
Working out if people liked the sort of name changes I'd done was
exactely one of the reasons I posted these patches - I'll think of
better names than just prefixing with "_" for future patches.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/