Re: [PATCH] blktrace: readahead support

On Mon, Jul 10, 2006 at 12:46:03AM -0500, Milton Miller wrote:
> > +#define trace_ahead_bit(rw)	\
> > +	(((rw) & (1 << BIO_RW_AHEAD)) << (BIO_RW_AHEAD - 0))
> ...
> I think the shift should be << (2 - BIO_RW_AHEAD).

Quite possibly.  As long as it ends up in slot 4 in that array still..
which it will.

cheers.

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] blktrace: readahead support
    • From: Milton Miller <[email protected]>

• Prev by Date: RE: [BUG] sleeping function called from invalid context during resume
• Next by Date: Re: [PATCH 2/3] disallow modular binfmt_elf32
• Previous by thread: Re: [PATCH] blktrace: readahead support
• Next by thread: Re: [PATCH] blktrace: readahead support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]