On Fri, 07 Jul 2006 10:54:36 +0100
David Howells <[email protected]> wrote:
> Andrew Morton <[email protected]> wrote:
>
> > > +#define roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y))
> >
> > The GFS2 tree has
> >
> > ...
> > +#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))
>
> They aren't exactly equivalent.
OK.
I count 45 different implementations of this in the tree. Ho hum.
> In any case, we probably shouldn't be using divide, but should rather be using
> shifts since the divisors are powers of two. I wonder if the compiler will
> make the substitution...
>
It usually manages to. iirc, less successfully if signed quantities are
used.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
