On July 06 at 19:50 EDT, Pavel Machek hastily scribbled: > Apart from codingstyle issues... I've fixed a bunch that Andrew Morton and Richard Purdie mentioned (since your message, I've posted a new revision). Are there any changes I missed? > yes, it looks good. Nice. :-) > Hooking various > leds into led subsystem is way better than having all the separate > drivers. Yes. The LED subsystem is a really cool idea, because what good are blinkenlights if you have to write shell scripts to control them? The kernel should do that for you! (/me wishes someone made a laptop with something like 8 LED's of different colors, so he could just make them do what he liked.) > I guess I'll have to convert ibm_acpi... I'm willing to take a first whack at it, if you can put me in touch with someone to test it. --Thomas Tuttle
Attachment:
pgpogn6lD0qli.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem
- From: Pavel Machek <[email protected]>
- Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem
- References:
- [PATCH] Integrate asus_acpi LED's with new LED subsystem
- From: Thomas Tuttle <[email protected]>
- Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem
- From: Pavel Machek <[email protected]>
- [PATCH] Integrate asus_acpi LED's with new LED subsystem
- Prev by Date: Re: Generic interface for accelerometers (AMS, HDAPS, ...)
- Next by Date: [PATCH] Miniconfig revisited (2/3)
- Previous by thread: Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem
- Next by thread: Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem
- Index(es):
 |