RE: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced

> > <--  snip  -->
> > 
> > Note that tp is never assigned any value other than NULL (and the 
> > Coverity checker found a way how tp might be dereferenced four 
> > function calls later).
> 
> Then the bug is probably in the function call that uses tp 
> without first checking whether it's null. Can you tell us 
> where that dereference occurs?
> 
> Cheers,
> 
> Dave.

Maybe, but the above code is confusing too.

Why not get rid of tp and explicitly pass NULL as "xfs_dir_getdents(NULL, dp, uiop, eofp);"?

Hua

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced
    • From: David Chinner <[email protected]>

• Prev by Date: Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems
• Next by Date: Linux v2.6.18-rc1/reiserfs INFO: possible recursive locking detected
• Previous by thread: Re: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced
• Next by thread: Re: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]