* Siddha, Suresh B <[email protected]> wrote: > - if (sd && sd->flags & flag) > + if (sd && !(sd->flags & flag)) use test_sd_flag() here, as i did in my fix patch. > -#define test_sd_flag(sd, flag) ((sd && sd->flags & flag) ? 1 : 0) > +#define test_sd_flag(sd, flag) ((sd && (sd->flags & flag)) ? 1 : 0) remove the 'sd' check in test_sd_flag. In the other cases we know that there's an sd. (it's usually a sign of spaghetti code if tests like this include a check for the existence of the object checked) Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch] sched: fix macro -> inline function conversion bug
- From: "Siddha, Suresh B" <[email protected]>
- Re: [patch] sched: fix macro -> inline function conversion bug
- References:
- 2.6.17-mm5
- From: "Martin J. Bligh" <[email protected]>
- Re: 2.6.17-mm5
- From: Andrew Morton <[email protected]>
- [patch] sched: fix macro -> inline function conversion bug
- From: Ingo Molnar <[email protected]>
- Re: [patch] sched: fix macro -> inline function conversion bug
- From: Andrew Morton <[email protected]>
- Re: [patch] sched: fix macro -> inline function conversion bug
- From: Ingo Molnar <[email protected]>
- Re: [patch] sched: fix macro -> inline function conversion bug
- From: Ingo Molnar <[email protected]>
- Re: [patch] sched: fix macro -> inline function conversion bug
- From: "Siddha, Suresh B" <[email protected]>
- 2.6.17-mm5
- Prev by Date: Re: PCMCIA modem not found... resume/suspend helps some times... magic is not found
- Next by Date: regression / [PATCH] ACPI: fix fan/thermal resume
- Previous by thread: Re: [patch] sched: fix macro -> inline function conversion bug
- Next by thread: Re: [patch] sched: fix macro -> inline function conversion bug
- Index(es):
 |