Jeff,
I apologize for the incredibly late reply. Your objection of course
came up mere hours after I left on a vacation of nearly two weeks.
I also apologize for failing to CC linux-ide. I did, however,
originally CC the author of the Vitesse VSC driver (Jeremy Higdon).
The patch was submitted precisely because the PCI device ID was no
longer going to be single-use. In fact, shortly after the message
you posted below, Andrew posted the following (which has been queued
up for a month or so):
[patch 187/200] SGI IOC4: Detect IO card variant
In short, due to the unusual card design of the SGI IO10 card, and
the need to differentiate it from the SGI PCI-RT card, I was left
with no reasonable option other than to look for the existence of
the Vitesse device at a known PCI bus location. As such I needed
to re-use the PCI ID of the Vitesse part, thereby making it dual-use
and qualifying it for assignment of a PCI_DEVICE_ID_xxx constant.
I did perhaps overstep by also creating a PCI_DEVICE_ID_xxx constant
for the purportedly identical Intel part. Am I allowed a third apology
within a single email?
Brent
On Thu, 22 Jun 2006, Jeff Garzik wrote:
> WTF? This is a REGRESSION from the repeatedly expressed desire -- clear
> throughout libata -- that single-use PCI device IDs should not ever receive
> PCI_DEVICE_ID_xxx constants.
>
> I'm going to queue up a revert patch for this silliness.
>
> Next time, please let the relevant maintainer(s) know when you are touching
> their driver, so they have a chance to filter out the crap.
>
> This was -never- sent to me or linux-ide, or otherwise brought to the
> attention of the maintainers.
--
Brent Casavant All music is folk music. I ain't
[email protected] never heard a horse sing a song.
Silicon Graphics, Inc. -- Louis Armstrong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
