Re: [PATCH] hisax fix usage of __init*

[Arjan van de Ven <arjan@infradead.org>]

On Wed, 2006-07-05 at 13:23 +0200, Karsten Keil wrote:
> diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
> index 5333be5..e103503 100644
> --- a/drivers/isdn/hisax/config.c
> +++ b/drivers/isdn/hisax/config.c
> @@ -1875,7 +1875,7 @@ static void EChannel_proc_rcv(struct his
>  #ifdef CONFIG_PCI
>  #include <linux/pci.h>
>  
> -static struct pci_device_id hisax_pci_tbl[] __initdata = {
> +static struct pci_device_id hisax_pci_tbl[] __devinitdata = {
>  #ifdef CONFIG_HISAX_FRITZPCI
>         {PCI_VENDOR_ID_AVM,      PCI_DEVICE_ID_AVM_A1,
> PCI_ANY_ID, PCI_ANY_ID},
>  #endif
> diff --git a/drivers

I think this bit is still buggy; afaik pci_device_id tables should not
be of any kind of __init at all... CC'ing Greg just to make sure I'm not
talking rubbish

Greetings,
   Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/